fix: ContentHoverWidget respects Theia styles
#14836
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Customize the default `ContentHoverWidget` behavior to ensure it uses Theia styles when calculating available space for the hover widget. VS Code uses 30 pixel for top height, and 24 pixels for bottom height, but Theia uses 32 pixel for the top and 22 for the bottom. Closes eclipse-theia#14826
packages/toolbar/src/browser/application-shell-with-toolbar-override.ts
Outdated
Show resolved
Hide resolved
- use 30px instead of 32px - change api from set to adjust to remove top panel dependency from the toolbar code
kittaakos
commented
Feb 5, 2025
|
In-action with c198028: Screen.Recording.2025-02-05.at.15.47.31.movScreen.Recording.2025-02-05.at.15.51.17.mov |
If it's optional to leave it blank for now, I would choose to do so; I’m not quite sure what should or could go there at this time. Thank you! |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Customize the default
ContentHoverWidgetbehavior to ensure it uses Theia styles when calculating available space for the hover widget.VS Code uses 30 pixels for the top height and 24 pixels for the bottom height, but Theia uses 32 pixels for the top and 22 for the bottom.
Closes #14826
This PR fixes the available space calculation for the content hover widget in the monaco editor. As described in #14826, the Theia top and bottom height (menu + status bar) are different in VS Code. In some cases, the popup either was on the menu or was hidden under the Theia toolbar. This PR fixes both cases.
How to test
Please, as shown in the issue, try to make the editor hover either overlay the menu or hide below the toolbar when active. Let me know if you still find glitches.
In-action:
theia14826_part1.mov
theia14826_part2.mov
Follow-ups
Breaking changes
Attribution
Review checklist
Reminder for reviewers